Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Registry install on windows #257

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Fix Registry install on windows #257

merged 1 commit into from
Aug 11, 2022

Conversation

RyanJField
Copy link
Collaborator

Fixes issue with Windows 10 trying to load the store python.

@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RyanJField RyanJField mentioned this pull request Aug 5, 2022
Closed
@bobturneruk
Copy link
Contributor

Tag me for review whenever.

@RyanJField
Copy link
Collaborator Author

@bobturneruk This should fix the windows issue, can you test with the app executable aliases on please.

The tests are failing because GRID moved to ror and will be fixed with a merge of the feature/address_on_local branch.

@bobturneruk
Copy link
Contributor

Will do, but may not be today.

@RyanJField
Copy link
Collaborator Author

Will do, but may not be today.

No rush

bobturneruk
bobturneruk approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@bobturneruk bobturneruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can use this branch to install on Windows 10, Python 10 (Anaconda).

It seems some of the CI is currently failing on Ubuntu - not sure why.

Perhaps moving (some of) the CI onto an OS matrix including Windows would now be possible.

@RyanJField
Copy link
Collaborator Author

I can use this branch to install on Windows 10, Python 10 (Anaconda).

It seems some of the CI is currently failing on Ubuntu - not sure why.

Perhaps moving (some of) the CI onto an OS matrix including Windows would now be possible.

The failing (CI) tests should be fixed by #256, the GRID API is now defunct and needed to be moved to ROR.

@bobturneruk bobturneruk mentioned this pull request Aug 11, 2022
Merged
@RyanJField RyanJField merged commit 93e378c into develop Aug 11, 2022
@RyanJField RyanJField deleted the hotfix/python-exec-fix branch September 8, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobturneruk bobturneruk bobturneruk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanJField @bobturneruk